Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove #[allow(unused_variables)] from visitor methods #8828

Merged
merged 17 commits into from
Nov 25, 2023
Merged

Remove #[allow(unused_variables)] from visitor methods #8828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
86d799d
Update existing string nodes for implicit concatenation
dhruvmanila Nov 21, 2023
223380f
Update parser for the new AST design
dhruvmanila Nov 21, 2023
21ed36c
Update parser snapshots
dhruvmanila Nov 21, 2023
0c6e2e7
Add `AnyNode`/`AnyNodeRef` variants for string parts
dhruvmanila Nov 21, 2023
59ef011
Add methods for string parts in visitor implementation
dhruvmanila Nov 21, 2023
6be8eca
Update `ComparableExpr` to account for each string parts
dhruvmanila Nov 21, 2023
1c6dc52
Update the AST helper methods
dhruvmanila Nov 21, 2023
da89c76
Update the `Generator` for the new AST design
dhruvmanila Nov 21, 2023
6cdf149
misc: use `Self` consistently
dhruvmanila Nov 21, 2023
95f71da
Move `is_implicit_concatenated` to a narrow type
dhruvmanila Nov 21, 2023
6d6e1c7
Update the linter code for the new AST design
dhruvmanila Nov 21, 2023
bcabcca
Update the formatter code for the new AST design
dhruvmanila Nov 21, 2023
8193ff9
Implement `PartialEq` for `ConcatenatedStringLiteral`
dhruvmanila Nov 22, 2023
1e72af2
misc: use correct names for visitor arguments
dhruvmanila Nov 23, 2023
8b261bc
Explicit `as_str` (no deref), add no allocation methods
dhruvmanila Nov 23, 2023
c5cb958
Remove `#[allow(unused_variables)]` from visitor methods
dhruvmanila Nov 23, 2023
362d7fd
Merge branch 'main' into dhruv/remove-allow
dhruvmanila Nov 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 14 additions & 18 deletions crates/ruff_python_ast/src/visitor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,34 +757,30 @@ pub fn walk_pattern_keyword<'a, V: Visitor<'a> + ?Sized>(
visitor.visit_pattern(&pattern_keyword.pattern);
}

#[allow(unused_variables)]
pub fn walk_expr_context<'a, V: Visitor<'a> + ?Sized>(visitor: &V, expr_context: &'a ExprContext) {}
pub fn walk_expr_context<'a, V: Visitor<'a> + ?Sized>(
_visitor: &V,
_expr_context: &'a ExprContext,
) {
}

#[allow(unused_variables)]
pub fn walk_bool_op<'a, V: Visitor<'a> + ?Sized>(visitor: &V, bool_op: &'a BoolOp) {}
pub fn walk_bool_op<'a, V: Visitor<'a> + ?Sized>(_visitor: &V, _bool_op: &'a BoolOp) {}

#[allow(unused_variables)]
pub fn walk_operator<'a, V: Visitor<'a> + ?Sized>(visitor: &V, operator: &'a Operator) {}
pub fn walk_operator<'a, V: Visitor<'a> + ?Sized>(_visitor: &V, _operator: &'a Operator) {}

#[allow(unused_variables)]
pub fn walk_unary_op<'a, V: Visitor<'a> + ?Sized>(visitor: &V, unary_op: &'a UnaryOp) {}
pub fn walk_unary_op<'a, V: Visitor<'a> + ?Sized>(_visitor: &V, _unary_op: &'a UnaryOp) {}

#[allow(unused_variables)]
pub fn walk_cmp_op<'a, V: Visitor<'a> + ?Sized>(visitor: &V, cmp_op: &'a CmpOp) {}
pub fn walk_cmp_op<'a, V: Visitor<'a> + ?Sized>(_visitor: &V, _cmp_op: &'a CmpOp) {}

#[allow(unused_variables)]
pub fn walk_alias<'a, V: Visitor<'a> + ?Sized>(visitor: &V, alias: &'a Alias) {}
pub fn walk_alias<'a, V: Visitor<'a> + ?Sized>(_visitor: &V, _alias: &'a Alias) {}

#[allow(unused_variables)]
pub fn walk_string_literal<'a, V: Visitor<'a> + ?Sized>(
visitor: &V,
string_literal: &'a StringLiteral,
_visitor: &V,
_string_literal: &'a StringLiteral,
) {
}

#[allow(unused_variables)]
pub fn walk_bytes_literal<'a, V: Visitor<'a> + ?Sized>(
visitor: &V,
bytes_literal: &'a BytesLiteral,
_visitor: &V,
_bytes_literal: &'a BytesLiteral,
) {
}
30 changes: 13 additions & 17 deletions crates/ruff_python_ast/src/visitor/transformer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,30 +743,26 @@ pub fn walk_pattern_keyword<V: Transformer + ?Sized>(
visitor.visit_pattern(&mut pattern_keyword.pattern);
}

#[allow(unused_variables)]
pub fn walk_expr_context<V: Transformer + ?Sized>(visitor: &V, expr_context: &mut ExprContext) {}
pub fn walk_expr_context<V: Transformer + ?Sized>(_visitor: &V, _expr_context: &mut ExprContext) {}

#[allow(unused_variables)]
pub fn walk_bool_op<V: Transformer + ?Sized>(visitor: &V, bool_op: &mut BoolOp) {}
pub fn walk_bool_op<V: Transformer + ?Sized>(_visitor: &V, _bool_op: &mut BoolOp) {}

#[allow(unused_variables)]
pub fn walk_operator<V: Transformer + ?Sized>(visitor: &V, operator: &mut Operator) {}
pub fn walk_operator<V: Transformer + ?Sized>(_visitor: &V, _operator: &mut Operator) {}

#[allow(unused_variables)]
pub fn walk_unary_op<V: Transformer + ?Sized>(visitor: &V, unary_op: &mut UnaryOp) {}
pub fn walk_unary_op<V: Transformer + ?Sized>(_visitor: &V, _unary_op: &mut UnaryOp) {}

#[allow(unused_variables)]
pub fn walk_cmp_op<V: Transformer + ?Sized>(visitor: &V, cmp_op: &mut CmpOp) {}
pub fn walk_cmp_op<V: Transformer + ?Sized>(_visitor: &V, _cmp_op: &mut CmpOp) {}

#[allow(unused_variables)]
pub fn walk_alias<V: Transformer + ?Sized>(visitor: &V, alias: &mut Alias) {}
pub fn walk_alias<V: Transformer + ?Sized>(_visitor: &V, _alias: &mut Alias) {}

#[allow(unused_variables)]
pub fn walk_string_literal<V: Transformer + ?Sized>(
visitor: &V,
string_literal: &mut StringLiteral,
_visitor: &V,
_string_literal: &mut StringLiteral,
) {
}

#[allow(unused_variables)]
pub fn walk_bytes_literal<V: Transformer + ?Sized>(visitor: &V, bytes_literal: &mut BytesLiteral) {}
pub fn walk_bytes_literal<V: Transformer + ?Sized>(
_visitor: &V,
_bytes_literal: &mut BytesLiteral,
) {
}
Loading