Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generate formatter nodes for string parts #8837

Merged
merged 2 commits into from
Nov 25, 2023
Merged

Conversation

dhruvmanila
Copy link
Member

A follow-up to auto-generate the FormatNodeRule implementation for the string part nodes. This is just a dummy implementation that is unreachable because it's handled by the parent nodes.

@dhruvmanila
Copy link
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@dhruvmanila dhruvmanila added the formatter Related to the formatter label Nov 25, 2023
@dhruvmanila
Copy link
Member Author

I forgot to run this script before. \cc @konstin should we create a CI step to make sure this is checked?

@dhruvmanila dhruvmanila enabled auto-merge (squash) November 25, 2023 12:56
@dhruvmanila dhruvmanila merged commit 1dbfab9 into main Nov 25, 2023
16 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/formatted-nodes branch November 25, 2023 13:00
Copy link
Contributor

ruff-ecosystem results

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@MichaReiser
Copy link
Member

Is the idea to move the formatting implementations to these nodes later? If not, then I don't see the value of having the format implementations (that can't format anything). Should we instead exclude the nodes in the generate script?

@dhruvmanila
Copy link
Member Author

Is the idea to move the formatting implementations to these nodes later? If not, then I don't see the value of having the format implementations (that can't format anything). Should we instead exclude the nodes in the generate script?

That's a good point. I haven't spent much time on it but I think it would be beneficial to move the formatting implementations to those nodes. I can revert the change later if it's not useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatter Related to the formatter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants