-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use double quotes for all docstrings, including single-quoted docstrings #9020
Conversation
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
0a21edf
to
bd8b9b0
Compare
|
e19ea42
to
9993bb0
Compare
9993bb0
to
6286396
Compare
42c6891
to
fadaddd
Compare
6286396
to
56cb6ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be even more opinionated and change quotes to triple quotes
I'd favor this, because single quotes obfuscate that the statement is a docstring
56cb6ac
to
9cb815b
Compare
Summary
This PR changes our docstring formatting to enforce double quotes for single-quoted docstrings (and not just triple-quoted strings).
I see reasons for and against this.
Alternatives:
I favor the consistency of what we consider docstrings and how we format them.
Test Plan
Added test