Support variable keys in static dictionary key rule #9411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/B
branch
from
3836069
to
66c80da
Compare
charliermarsh
force-pushed
the
charlie/B
branch
from
66c80da
to
8ccebc4
Compare
|
| {(1, "a"): value.upper() for value in data} # constant tuple | ||
| {(1, "a"): value.upper() for value in data} # Constant tuple | ||
| {constant: value.upper() for value in data} | ||
| {constant + constant: value.upper() for value in data} |
There was a problem hiding this comment.
awesome 🎉, so quick :)
I dont know if this is a common use case but I guess one case not covered here is if the key in an attr.
e.g.
{SomeClass.CONSTANT: val for val in data}
{Some.Class.CONSTANT: val for val in data}There was a problem hiding this comment.
Good call, let me test that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9410.