Use a trie-based router to resolve per-file settings #9444
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a small change that I put together a while ago but forgot to clean up. When the formatter is fully cached, it turns out we actually spend meaningful time mapping from file to
Settings
(since we use a hierarchical approach to settings). Usingmatchit
rather thanBTreeMap
improves fully-cached performance by anywhere from 2-5% depending on the project, and since these are all implementation details ofResolver
, it's minimally invasive.We don't need all the behavior of
matchit
, but I tried other libraries likeradix_trie
and didn't see any speedup vs.main
, whereasmatchit
shows a consistent improvement.Test Plan