Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for possibly-empty f-string values in truthiness logic #9484

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Account for possibly-empty f-string values in truthiness logic #9484

merged 1 commit into from
Jan 12, 2024

Conversation

charliermarsh
Copy link
Member

Closes #9479.

@charliermarsh charliermarsh added the bug Something isn't working label Jan 12, 2024
@charliermarsh charliermarsh marked this pull request as ready for review January 12, 2024 01:49
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@charliermarsh charliermarsh merged commit a31a314 into main Jan 12, 2024
17 checks passed
@charliermarsh charliermarsh deleted the charlie/f-string branch January 12, 2024 02:16
@Porkepix Porkepix mentioned this pull request Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SIM222: false positive on format strings
1 participant
@charliermarsh