Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IfExp with dual string arms in invalid-envvar-default #9734

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

covracer
Copy link
Contributor

Summary

Just like #6537 and #6538 but for the default second parameter to getenv().

Also rename "BAD" to "BAR" in the tests, since those strings shouldn't trigger the rule.

Test Plan

Added passing and failing examples to invalid_envvar_default.py.

Just like astral-sh#6537 and astral-sh#6538 but for the `default` second parameter to `getenv()`.

Also rename "BAD" to "BAR" in the tests, since those strings shouldn't trigger the rule.
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh
Copy link
Member

Nice, thank you!

@charliermarsh charliermarsh added the bug Something isn't working label Jan 31, 2024
@charliermarsh charliermarsh merged commit 7ae7bf6 into astral-sh:main Jan 31, 2024
17 checks passed
@covracer covracer deleted the invalid-envvar-default branch February 3, 2024 01:09
covracer added a commit to biobuddies/allowedflare that referenced this pull request Mar 1, 2024
Account for the possibility of different top level domains between
private stuff and public-facing stuff like email addresses.

Put a 3-second timeout on the certificates request, just in case.

Bump the Ruff version to pick up
astral-sh/ruff#9734 and update some other
tooling. Also prepare for running more linters with Ruff and replacing
`black` with [The Ruff
Formatter](https://docs.astral.sh/ruff/formatter/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants