Support IfExp with dual string arms in invalid-envvar-default
#9734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like astral-sh#6537 and astral-sh#6538 but for the `default` second parameter to `getenv()`. Also rename "BAD" to "BAR" in the tests, since those strings shouldn't trigger the rule.
|
|
Nice, thank you! |
covracer
added a commit
to biobuddies/allowedflare
that referenced
this pull request
Mar 1, 2024
Account for the possibility of different top level domains between private stuff and public-facing stuff like email addresses. Put a 3-second timeout on the certificates request, just in case. Bump the Ruff version to pick up astral-sh/ruff#9734 and update some other tooling. Also prepare for running more linters with Ruff and replacing `black` with [The Ruff Formatter](https://docs.astral.sh/ruff/formatter/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just like #6537 and #6538 but for the
defaultsecond parameter togetenv().Also rename "BAD" to "BAR" in the tests, since those strings shouldn't trigger the rule.
Test Plan
Added passing and failing examples to
invalid_envvar_default.py.