Removing trailing whitespace inside multiline strings is unsafe #9744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crates/ruff_linter/src/rules/pycodestyle/rules/trailing_whitespace.rs
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,2 @@ | |||
| '''trailing whitespace | |||
| inside a multiline string''' | |||
There was a problem hiding this comment.
Do you mind adding a test for a multi-line f-string here?
There was a problem hiding this comment.
I added a test and it failed! From a brief look, it didn't seem trivial, and I would prefer to do this as a separate PR.
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| W291 | 20 | 0 | 0 | 0 | 20 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+0 -0 violations, +0 -20 fixes in 2 projects; 41 projects unchanged)
latchbio/latch (+0 -0 violations, +0 -8 fixes)
ruff check --no-cache --exit-zero --preview
+ latch/resources/map_tasks.py:2:60: W291 Trailing whitespace - latch/resources/map_tasks.py:2:60: W291 [*] Trailing whitespace + latch/resources/map_tasks.py:3:61: W291 Trailing whitespace - latch/resources/map_tasks.py:3:61: W291 [*] Trailing whitespace + latch/resources/map_tasks.py:4:60: W291 Trailing whitespace - latch/resources/map_tasks.py:4:60: W291 [*] Trailing whitespace + latch/resources/map_tasks.py:5:58: W291 Trailing whitespace - latch/resources/map_tasks.py:5:58: W291 [*] Trailing whitespace
reflex-dev/reflex (+0 -0 violations, +0 -12 fixes)
ruff check --no-cache --exit-zero --preview
+ reflex/.templates/apps/demo/code/pages/datatable.py:204:140: W291 Trailing whitespace - reflex/.templates/apps/demo/code/pages/datatable.py:204:140: W291 [*] Trailing whitespace + reflex/.templates/apps/demo/code/pages/datatable.py:205:156: W291 Trailing whitespace - reflex/.templates/apps/demo/code/pages/datatable.py:205:156: W291 [*] Trailing whitespace + reflex/.templates/apps/demo/code/pages/datatable.py:206:128: W291 Trailing whitespace - reflex/.templates/apps/demo/code/pages/datatable.py:206:128: W291 [*] Trailing whitespace + reflex/.templates/apps/demo/code/pages/datatable.py:207:100: W291 Trailing whitespace - reflex/.templates/apps/demo/code/pages/datatable.py:207:100: W291 [*] Trailing whitespace + reflex/.templates/apps/demo/code/pages/forms.py:21:32: W291 Trailing whitespace - reflex/.templates/apps/demo/code/pages/forms.py:21:32: W291 [*] Trailing whitespace + reflex/.templates/apps/demo/code/pages/forms.py:22:39: W291 Trailing whitespace - reflex/.templates/apps/demo/code/pages/forms.py:22:39: W291 [*] Trailing whitespace
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| W291 | 20 | 0 | 0 | 0 | 20 |
Formatter (stable)
ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)
openai/openai-cookbook (error)
warning: Detected debug build without --no-cache.
error: Failed to parse examples/dalle/Image_generations_edits_and_variations_with_DALL-E.ipynb:3:7:8: Unexpected token 'prompt'
Formatter (preview)
ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)
openai/openai-cookbook (error)
ruff format --preview
warning: Detected debug build without --no-cache.
error: Failed to parse examples/dalle/Image_generations_edits_and_variations_with_DALL-E.ipynb:3:7:8: Unexpected token 'prompt'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8037.