Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUF022, RUF023: Ensure closing parentheses for multiline sequences are always on their own line #9793

Merged
merged 4 commits into from
Feb 9, 2024

Do it without the regex

6fa2c43
Select commit
Loading
Failed to load commit list.
Merged

RUF022, RUF023: Ensure closing parentheses for multiline sequences are always on their own line #9793

Do it without the regex
6fa2c43
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis succeeded Feb 9, 2024 in 0s

Performance Gate Passed

Summary

⚡ 18 improvements
✅ 12 untouched benchmarks

Benchmarks breakdown

Benchmark main AlexWaygood:closing-paren Change
parser[numpy/globals.py] 1,117.4 µs 963.5 µs +15.98%
parser[large/dataset.py] 69.1 ms 63.5 ms +8.78%
lexer[numpy/globals.py] 223.5 µs 154.8 µs +44.39%
linter/all-rules[numpy/globals.py] 2.8 ms 2.6 ms +7.65%
lexer[unicode/pypinyin.py] 571.5 µs 526.5 µs +8.55%
linter/all-rules[pydantic/types.py] 44.3 ms 39.8 ms +11.4%
lexer[numpy/ctypeslib.py] 1.8 ms 1.6 ms +15.26%
linter/all-rules[unicode/pypinyin.py] 11.8 ms 10.2 ms +15.65%
parser[pydantic/types.py] 26.4 ms 24.4 ms +8.1%
parser[unicode/pypinyin.py] 4.3 ms 3.9 ms +9.89%
linter/all-rules[numpy/ctypeslib.py] 22 ms 18.9 ms +16.46%
linter/all-with-preview-rules[unicode/pypinyin.py] 12.8 ms 11.3 ms +13.33%
linter/all-with-preview-rules[numpy/globals.py] 3.1 ms 3 ms +4.09%
linter/all-with-preview-rules[pydantic/types.py] 51.9 ms 47.2 ms +9.9%
linter/all-with-preview-rules[numpy/ctypeslib.py] 24.6 ms 22 ms +11.8%
parser[numpy/ctypeslib.py] 11.8 ms 10.8 ms +9.85%
linter/all-rules[large/dataset.py] 94.1 ms 82.6 ms +13.83%
linter/all-with-preview-rules[large/dataset.py] 106.9 ms 96 ms +11.39%