Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LibCST-based fixer for C403 #9818

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Remove LibCST-based fixer for C403 #9818

merged 1 commit into from
Feb 5, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Experimenting with rewriting one of the comprehension fixes without LibCST.

@charliermarsh
Copy link
Member Author

This actually does a better job of preserving comments.

@charliermarsh charliermarsh marked this pull request as ready for review February 5, 2024 00:43
@charliermarsh charliermarsh added the fixes Related to suggested fixes for violations label Feb 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2024

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

sphinx-doc/sphinx (error) 

ruff failed
  Cause: Selection of unstable rules without the `--preview` flag is not allowed. Enable preview or remove selection of:
	- FURB113
	- FURB131
	- FURB132

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh changed the title Remove one usage of LibCST Remove LibCST-based fixer for C403 Feb 5, 2024
@charliermarsh charliermarsh merged commit dd77d29 into main Feb 5, 2024
17 checks passed
@charliermarsh charliermarsh deleted the charlie/lcst branch February 5, 2024 01:08
@miccal miccal mentioned this pull request Feb 6, 2024
Merged
@bswck bswck mentioned this pull request Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fixes Related to suggested fixes for violations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charliermarsh