Only log checksum is valid when it really is (#97)

astral-sh · Sep 21, 2024 · 8c3a35e · 8c3a35e
1 parent abac0ce
commit 8c3a35e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/dist/setup/index.js b/dist/setup/index.js
diff --git a/src/download/checksum/checksum.ts b/src/download/checksum/checksum.ts
@@ -12,7 +12,7 @@ export async function validateChecksum(
   platform: Platform,
   version: string,
 ): Promise<void> {
-  let isValid = true;
+  let isValid: boolean | undefined = undefined;
   if (checkSum !== undefined && checkSum !== "") {
     isValid = await validateFileCheckSum(downloadPath, checkSum);
   } else {
@@ -27,10 +27,12 @@ export async function validateChecksum(
     }
   }
 
-  if (!isValid) {
+  if (isValid === false) {
     throw new Error(`Checksum for ${downloadPath} did not match ${checkSum}.`);
   }
-  core.debug(`Checksum for ${downloadPath} is valid.`);
+  if (isValid === true) {
+    core.debug(`Checksum for ${downloadPath} is valid.`);
+  }
 }
 
 async function validateFileCheckSum(