Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 use GitHub token by default #61

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

burgholzer
Copy link
Contributor

This PR adjusts the action so that it is no longer necessary to explicitly specify the GitHub token to circumvent the API rate limit.
To this end, it simply passes the repository's GitHub token (available via ${{ github.token }}) as a default for the github_token action input.

This is similar to how this is handled in, e.g., https://github.com/peter-evans/create-pull-request; specifically here.

Copy link
Collaborator

@eifinger eifinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice thank you! I didn't know this was possible.

Some small requests and we can merge this.

.github/workflows/test.yml Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Collaborator

@eifinger eifinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you!

@eifinger eifinger enabled auto-merge (squash) September 11, 2024 08:17
@eifinger eifinger merged commit 49df72d into astral-sh:main Sep 11, 2024
37 checks passed
@henryiii
Copy link

Nice, I suggested this on Discord a while back, happy to see it in!

@burgholzer
Copy link
Contributor Author

Nice, I suggested this on Discord a while back, happy to see it in!

That's what motivated me to look into it 😉

nikaro added a commit to nikaro/commitizen-action that referenced this pull request Sep 22, 2024
Set `${{ github.token }}` as the default value for `github_token` input.
This is the common practice, examples:

* https://github.com/actions/checkout/blob/main/action.yml#L24
* astral-sh/setup-uv#61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants