Change preserve_permissions to avoid modifying permissions at all
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
changed the title
preserve_permissions to avoid modifying permissions at all
konstin
approved these changes
Feb 3, 2025
charliermarsh
added a commit
to astral-sh/uv
that referenced
this pull request
Feb 3, 2025
## Summary As in our zip operation (and like pip), we want to explicitly avoid setting permissions during unpacking -- apart from setting the executable bit. This depends on astral-sh/tokio-tar#8. Closes #11188.
konstin
added a commit
that referenced
this pull request
Feb 4, 2025
Adapt the directory permissions test to the changes made in #8.
konstin
added a commit
that referenced
this pull request
Feb 4, 2025
Adapt the directory permissions test to the changes made in #8, to fix the test suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Right now,
preserve_permissionsonly affects extended permissions, i.e., non-permission bits (viamode & 0o777). So thesuidand such are not retained. However, the read, write, and execute permissions are retained. We don't want that.pipexplicitly does not preserve any permissions apart from the executable bit, which we handle out-of-band from the unpack in uv.