Avoid cloning requirement for unchanged markers (#6116)

## Summary Small optimization.
astral-sh · Aug 15, 2024 · 4d13b52 · 4d13b52
1 parent 984346f
commit 4d13b52
Showing 1 changed file with 22 additions and 14 deletions.
diff --git a/crates/uv-resolver/src/resolver/mod.rs b/crates/uv-resolver/src/resolver/mod.rs
@@ -1524,13 +1524,17 @@ impl<InstalledPackages: InstalledPackagesProvider> ResolverState<InstalledPackag
                         return None;
                     }
 
-                    Cow::Owned(Requirement {
-                        name: requirement.name.clone(),
-                        extras: requirement.extras.clone(),
-                        source: requirement.source.clone(),
-                        origin: requirement.origin.clone(),
-                        marker
-                    })
+                    if marker == requirement.marker {
+                        requirement
+                    } else {
+                        Cow::Owned(Requirement {
+                            name: requirement.name.clone(),
+                            extras: requirement.extras.clone(),
+                            source: requirement.source.clone(),
+                            origin: requirement.origin.clone(),
+                            marker
+                        })
+                    }
                 } else {
                     requirement
                 };
@@ -1591,13 +1595,17 @@ impl<InstalledPackages: InstalledPackagesProvider> ResolverState<InstalledPackag
                                     return None;
                                 }
 
-                                Cow::Owned(Requirement {
-                                    name: constraint.name.clone(),
-                                    extras: constraint.extras.clone(),
-                                    source: constraint.source.clone(),
-                                    origin: constraint.origin.clone(),
-                                    marker
-                                })
+                                if marker == constraint.marker {
+                                    Cow::Borrowed(constraint)
+                                } else {
+                                    Cow::Owned(Requirement {
+                                        name: constraint.name.clone(),
+                                        extras: constraint.extras.clone(),
+                                        source: constraint.source.clone(),
+                                        origin: constraint.origin.clone(),
+                                        marker
+                                    })
+                                }
                             } else {
                                 // Additionally, if the requirement is `requests ; sys_platform == 'darwin'`
                                 // and the constraint is `requests ; python_version == '3.6'`, the