Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install instructions for Windows command prompt #1750

Closed
12932 opened this issue Feb 20, 2024 · 3 comments · Fixed by #1811
Closed

Install instructions for Windows command prompt #1750

12932 opened this issue Feb 20, 2024 · 3 comments · Fixed by #1811
Labels
documentation Improvements or additions to documentation windows Specific to the Windows platform

Comments

@12932
Copy link
Contributor

12932 commented Feb 20, 2024

In the README.md document

It says "On Windows." , and then provides a Powershell-only compatible command. Running it in my command prompt gave me an error:

'irm' is not recognized as an internal or external command,
operable program or batch file.

It works fine in Powerhsell. I think the readme should say powershell only for that specific command
@AlexWaygood AlexWaygood added documentation Improvements or additions to documentation good first issue Good for newcomers windows Specific to the Windows platform labels Feb 20, 2024
@AlexWaygood
Copy link
Member

AlexWaygood commented Feb 20, 2024 •
edited
Loading

Agreed. Ideally we'd give a command that worked on both PowerShell and CMD (or at least instructions for how to do things with the CMD shell). But for now, just documenting that this is a PowerShell-specific command would be an improvement. PR welcome!

@AlexWaygood
Copy link
Member

Looks like you documented this as being PowerShell specific in #1751 -- thanks!

I'll leave this open for now, though, as ideally we'd document a CMD command that works as well (or have a unified command that works on both).

@konstin konstin changed the title Windows instructions for Getting-started don't work in command prompt Install instructions fpr Windows command prompt Feb 20, 2024
@AlexWaygood AlexWaygood removed the good first issue Good for newcomers label Feb 20, 2024
@12932 12932 changed the title Install instructions fpr Windows command prompt Install instructions for Windows command prompt Feb 20, 2024
@konstin
Copy link
Member

konstin commented Feb 20, 2024

Ref: axodotdev/cargo-dist#458

@konstin konstin mentioned this issue Feb 21, 2024
Merged
@samypr100 samypr100 mentioned this issue Feb 21, 2024
Merged
AlexWaygood pushed a commit that referenced this issue Feb 21, 2024
@samypr100
docs: update venv activation for windows (#1836)
f441f8f 
## Summary

Follow on to PR #1811 as part of
issue #1750. This change updates
the windows venv activation to work for both Powershell and Command
Prompt instead of just Powershell. This also aligns with what `uv venv`
displays.
konstin added a commit that referenced this issue Feb 22, 2024
@konstin
Use more universal windows install instructions (#1811)
af06a6f 
Recommend installing uv on windows with

```
powershell -c "irm https://astral.sh/uv/install.ps1 | iex"
```

instead of

```
irm https://astral.sh/uv/install.ps1 | iex
```

to support installing on cmd.exe, the classic non-powershell windows
command prompt.

See axodotdev/cargo-dist#458 for background.
This will also be included in the next cargo-dist release.

I have confirmed this passes on
 * Command Prompt
 * Windows PowerShell
 * PowerShell
 * git bash

Closes #1750

CC @12932 this fixes the uv command prompt installation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation windows Specific to the Windows platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use more universal windows install instructions astral-sh/uv
3 participants
@konstin @AlexWaygood @12932