Failure with source installations

[sayakpaul]

I am on my Apple M2 and uv-0.1.31.

Running: uv pip install -U peft@git+https://github.com/huggingface/peft.git.

It's failing with:

error: Failed to download and build: peft @ git+https://github.com/huggingface/peft.git
  Caused by: Git operation failed
  Caused by: no URL configured for submodule 'examples/boft_dreambooth/data/dreambooth'; class=Submodule (17)

Didn't happen last week.

FWIW, uv pip install -U transformers@git+https://github.com/huggingface/transformers.git doesn't fail.

[zanieb]

Thanks for the report! Was it working with a previous version of uv or a different commit of the repository?

[sayakpaul]

A different commit of the repository being used.

Was able to pin-point:

uv pip install -U peft@git+https://github.com/huggingface/peft.git@b0f1bb468ce58a26c1403db37e2ca8a76977b4c1

This works. Things break after: huggingface/peft#1326.

[zanieb]

Thanks! I'll look into this

[zanieb]

Interesting I can't reproduce with a simple project

❯ cargo run -- pip install git+https://github.com/astral-test/uv-submodule-pypackage
    Finished dev [unoptimized + debuginfo] target(s) in 0.68s
     Running `target/debug/uv pip install 'git+https://github.com/astral-test/uv-submodule-pypackage'`
 Updated https://github.com/astral-test/uv-submodule-pypackage (d2c44b8)                                                     Resolved 1 package in 3ms
Installed 1 package in 3ms
 + uv-public-pypackage==0.1.0 (from git+https://github.com/astral-test/uv-submodule-pypackage@d2c44b87eef25896dd30a6e55d4689b918180c7b)

❯ cargo run -- pip install git+https://github.com/astral-test/uv-submodule-pypackage#subdirectory=submodule
    Finished dev [unoptimized + debuginfo] target(s) in 0.66s
     Running `target/debug/uv pip install 'git+https://github.com/astral-test/uv-submodule-pypackage#subdirectory=submodule'`
 Updated https://github.com/astral-test/uv-submodule-pypackage (d2c44b8)                                                     Resolved 1 package in 3ms
   Built uv-public-pypackage @ git+https://github.com/astral-test/uv-submodule-pypackage@d2c44b87eef25896dd30a6e55d4689b918180c7bDownloaded 1 package in 353ms
Installed 1 package in 1ms
 - uv-public-pypackage==0.1.0 (from git+https://github.com/astral-test/uv-submodule-pypackage@d2c44b87eef25896dd30a6e55d4689b918180c7b)
 + uv-public-pypackage==0.1.0 (from git+https://github.com/astral-test/uv-submodule-pypackage@d2c44b87eef25896dd30a6e55d4689b918180c7b#subdirectory=submodule)

[zanieb]

This seems like something legitimately wrong with their submodule?

[sayakpaul]

It works with regular pip, though.

[NeilGirdhar]

I'm getting the same problem:

uv pip install "git+https://github.com/gooogle/flax.git"
Updating https://github.com/gooogle/flax.git (HEAD)
Updating https://github.com/gooogle/flax.git (HEAD)
Updating https://github.com/gooogle/flax.git (HEAD)
Updating https://github.com/gooogle/flax.git (HEAD)                                                                                                                                       error: Git operation failed
  Caused by: failed to clone into: /Users/neil/Library/Caches/uv/git-v0/db/149b51fdacfaafab
  Caused by: process didn't exit successfully: `git fetch --force --update-head-ok 'https://github.com/gooogle/flax.git' '+HEAD:refs/remotes/origin/HEAD'` (exit status: 128)
--- stderr
remote: Repository not found.
fatal: Authentication failed for 'https://github.com/gooogle/flax.git/'

This works fine with normal pip.

[charliermarsh]

I'll take a look.

[charliermarsh]

@NeilGirdhar - I think you have a typo, three o's in Google.

[charliermarsh]

Ok so I've confirmed that pip doesn't recursively clone the contents of examples/boft_dreambooth/data/dreambooth either (but they clearly don't error).

[zanieb]

@charliermarsh I'm not sure what behavior is right here. I think we need to understand precisely what's wrong with that submodule setup to know if we should fail because of it or not.

Otherwise... you could install from git and be silently missing a meaningful part of the package.

[charliermarsh]

Yeah I can just fix the repo itself if necessary.

[charliermarsh]

I'll try now.

[charliermarsh]

I think uv is correct to fail here. I've submitted a PR to peft to modify the repo setup: huggingface/peft#1660