Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dreambooth Git link #1660

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Remove dreambooth Git link #1660

merged 3 commits into from
Apr 18, 2024

Conversation

charliermarsh
Copy link
Contributor

Summary

examples/boft_dreambooth/data/dreambooth is declared as a submodule, but there's no .gitmodules mapping for it, so various Git operations will fail on the repo.

data is actually already .gitignored, so it seems reasonable to just remove this submodule entirely, since cloning the repo (which is handled by the training script) won't lead to a dirty Git history anyway.

The alternative solution is to add a .gitmodules entry:

[submodule "dreambooth"]
    path = examples/boft_dreambooth/data/dreambooth
    url = https://github.com/google/dreambooth

The downside here is that you'll now be downloading the dataset whenever someone performs a recursive clone on the repo, which seems not to be the intent, since you're downloading the repo out-of-band from Git via the training script anyway.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. This example was originally structured differently so that it used the sub-module. Later, that was changed, but this wasn't cleaned up.

@BenjaminBossan BenjaminBossan merged commit bdb8567 into huggingface:main Apr 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants