Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--emit-index-annotation should redact usernames and passwords in index URL #3106

Closed
nicodemus26 opened this issue Apr 17, 2024 · 3 comments · Fixed by #3112
Closed

--emit-index-annotation should redact usernames and passwords in index URL #3106

nicodemus26 opened this issue Apr 17, 2024 · 3 comments · Fixed by #3112
Labels
bug Something isn't working help wanted Contribution especially encouraged

Comments

@nicodemus26
Copy link

nicodemus26 commented Apr 17, 2024 •
edited
Loading

e.g.

# from https://aws:asupersecretpasswordorauthtoken@my-account-123.d.codeartifact.us-west-2.amazonaws.com/pypi/my-private-repo/simple

->

# from https://my-account-123.d.codeartifact.us-west-2.amazonaws.com/pypi/my-private-repo/simple
@charliermarsh charliermarsh added the bug Something isn't working label Apr 17, 2024
@charliermarsh
Copy link
Member

Makes sense!

@charliermarsh charliermarsh added the help wanted Contribution especially encouraged label Apr 17, 2024
@zanieb
Copy link
Member

zanieb commented Apr 17, 2024

See also #1714

@zanieb
Copy link
Member

zanieb commented Apr 17, 2024

Something like...

uv/crates/uv-auth/src/middleware.rs

Line 95 in c0efeed

let _ = url.set_password(Some("****"));

@nicodemus26 nicodemus26 changed the title --emit-index-annotation should redact passwords in index URL --emit-index-annotation should redact usernames and passwords in index URL Apr 17, 2024
@ChannyClaus ChannyClaus mentioned this issue Apr 18, 2024
Merged
charliermarsh pushed a commit that referenced this issue Apr 18, 2024
@ChannyClaus
Hide password in the index printed via --emit-index-annotation (#3112)
8c7d0a3 
## Summary

resolves #3106

## Test Plan

added a simple test where the password provided in `UV_INDEX_URL` is
hidden in the output as expected.
@ewianda ewianda mentioned this issue Jul 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Contribution especially encouraged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide password in the index printed via --emit-index-annotation ChannyClaus/uv
3 participants
@nicodemus26 @charliermarsh @zanieb