Tagged commit for 0.2.14 does not match artifacts #4474
Labels
releases
Related to building and distributing release artifacts of uv
Comments
zanieb
added
the
releases
Merged
zanieb
added a commit
that referenced
this issue
Jun 24, 2024
Releasing 0.2.15 with a few additions over 0.2.14. Motivated by the incorrect tagging of 0.2.14 (#4474). Generated the changelog with a small patch to Rooster allowing me to force the previous commit to be correct. ```diff diff --git a/src/rooster/_cli.py b/src/rooster/_cli.py index 2a4f61b..4ec1299 100644 --- a/src/rooster/_cli.py +++ b/src/rooster/_cli.py @@ -38,6 +38,7 @@ def release( without_sections: list[str] = typer.Option( [], help="Sections to exclude from the changelog" ), + previous_commit: str = None, ): """ Create a new release. @@ -58,7 +59,11 @@ def release( typer.echo("It looks like there are no version tags for this project.") # Get the commits since the last release - changes = list(get_commits_between(config, repo, last_version)) + changes = list( + get_commits_between( + config, repo, last_version, force_first_commit=previous_commit + ) + ) since = "since last release" if last_version else "in the project" typer.echo(f"Found {len(changes)} commits {since}.") diff --git a/src/rooster/_git.py b/src/rooster/_git.py index 597bb88..66bc54e 100644 --- a/src/rooster/_git.py +++ b/src/rooster/_git.py @@ -29,12 +29,13 @@ def get_commits_between( target: Path, first_version: Version | None = None, second_version: Version | None = None, + force_first_commit: str | None = None, ) -> Generator[git.Commit, None, None]: """ Yield all commits between two tags """ repo = git.repository.Repository(target.absolute()) - first_commit = ( + first_commit = force_first_commit or ( repo.lookup_reference( TAG_PREFIX + config.version_tag_prefix + str(first_version) ) ```
|
We're releasing 0.2.15 now to minimize the effect of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm not sure if there's anything we can do here (now that it's happened), but our release tooling tagged f073088 instead of e0ad649 during the re-run of the failed 0.2.14 release.
The artifacts were all built for the proper commit, but the git tag points to an incorrect source.
See #4432 for details on the original problem.
The text was updated successfully, but these errors were encountered: