Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uv tool install ruff --force --reinstall is not idempotent #4692

Closed
charliermarsh opened this issue Jul 1, 2024 · 3 comments · Fixed by #4697
Closed

uv tool install ruff --force --reinstall is not idempotent #4692

charliermarsh opened this issue Jul 1, 2024 · 3 comments · Fixed by #4697
Labels
preview Experimental behavior

Comments

@charliermarsh
Copy link
Member

charliermarsh commented Jul 1, 2024 •
edited
Loading

If I run cargo run tool install ruff --force --reinstall, it alternatives between the following.

Resolved 7 packages in 15ms
Installed 7 packages in 12ms
 + blinker==1.8.2
 + click==8.1.7
 + flask==3.0.3
 + itsdangerous==2.2.0
 + jinja2==3.1.4
 + markupsafe==2.1.5
 + werkzeug==3.0.3
Installed: flask

And...

Resolved 7 packages in 14ms
Installed 7 packages in 22ms
 + blinker==1.8.2
 + click==8.1.7
 + flask==3.0.3
 + itsdangerous==2.2.0
 + jinja2==3.1.4
 + markupsafe==2.1.5
 + werkzeug==3.0.3
Updated environment for tool `flask`
@charliermarsh charliermarsh added the preview Experimental behavior label Jul 1, 2024
@charliermarsh
Copy link
Member Author

@zanieb - in theory could --force be dropped in favor of --reinstall?

@charliermarsh charliermarsh mentioned this issue Jul 1, 2024
Merged
@charliermarsh
Copy link
Member Author

Got it, I see:

// Note we use `reinstall_entry_points` here instead of `reinstall`; requesting reinstall
// will _not_ remove existing entry points when they are not managed by uv.

@zanieb
Copy link
Member

zanieb commented Jul 1, 2024

Mhm I think they need to be separate for that reason.

charliermarsh added a commit that referenced this issue Jul 1, 2024
@charliermarsh
Reinstall entrypoints with --force (#4697)
65cd676 
## Summary

I think this may have just been a typo.

Closes #4692.

## Test Plan

Run `cargo run tool install flask --force --reinstall` repeatedly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
preview Experimental behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reinstall entrypoints with --force astral-sh/uv
2 participants
@charliermarsh @zanieb