-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uv tries to read project.name
whenever the project
table is present
#6760
Comments
Thanks for the report! Technically, I think it's a violation of the specification to exclude the From the relevant document:
I believe the problem is that we see a I see a few options:
|
I'm also reading a bit into the linked issue regarding the implicit table definition — please let me know if you think it's wrong to fail if |
It's invalid. Tools are supposed to error out. I really dislike that it's required, but not up to me. :) See pypa/cibuildwheel#1064. |
We got user reports where users were confused about why they can't use `[project.urls]` without other `pyproject.toml`. This PR adds a hint that (according to PEP 621), you need to set `project.name` when using any `project` fields`. (PEP 621 also requires `project.version` xor `dynamic = ["version"]`, but we check that later.) The intermediate parsing layer to tell apart syntax errors from schema errors doesn't incur a performance penalty according to epage (toml-rs/toml#778 (comment)). Closes #6419 Closes #6760
We got user reports where users were confused about why they can't use `[project.urls]` without other `pyproject.toml`. This PR adds a hint that (according to PEP 621), you need to set `project.name` when using any `project` fields`. (PEP 621 also requires `project.version` xor `dynamic = ["version"]`, but we check that later.) The intermediate parsing layer to tell apart syntax errors from schema errors doesn't incur a performance penalty according to epage (toml-rs/toml#778 (comment)). Closes #6419 Closes #6760
We got user reports where users were confused about why they can't use `[project.urls]` without other `pyproject.toml`. This PR adds a hint that (according to PEP 621), you need to set `project.name` when using any `project` fields`. (PEP 621 also requires `project.version` xor `dynamic = ["version"]`, but we check that later.) The intermediate parsing layer to tell apart syntax errors from schema errors doesn't incur a performance penalty according to epage (toml-rs/toml#778 (comment)). Closes #6419 Closes #6760
If there's a In this case, it seems the project was mixing the With this in mind, UV's behavior is correct, however, to achieve better compatibility, I would suggest issuing a warning instead of erroring out in such scenarios. PS: Feel free to ping me if you have any more issues, or questions, regarding the project metadata, and other issues regarding packaging. |
I agree, though I wonder if it's worth reporting to the Poetry folks, specially since python-poetry/poetry-core#708 is just waiting to be released, and the frontend is WIP (python-poetry/poetry#9135). |
Here the package metadata may be at fault (quantile-development/dagster-ext#12), but both pypa/build and Poetry are able to build the project without any issues (even if with missing metadata).
The text was updated successfully, but these errors were encountered: