Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to define multiple, disjoint explicit indexes #7761

Closed
charliermarsh opened this issue Sep 28, 2024 · 0 comments
Closed

Allow users to define multiple, disjoint explicit indexes #7761

charliermarsh opened this issue Sep 28, 2024 · 0 comments
Assignees
@charliermarsh
Labels
enhancement New feature or improvement to existing functionality

Comments

@charliermarsh
Copy link
Member

I.e., this should work:

[project]
name = "project"
version = "0.1.0"
readme = "README.md"
requires-python = ">=3.12"
dependencies = ["jinja2"]

[tool.uv.sources]
jinja2 = [
    { index = "torch-cu118", marker = "sys_platform == 'darwin'"},
    { index = "torch-cu124", marker = "sys_platform != 'darwin'"},
]

[[tool.uv.index]]
name = "torch-cu118"
url = "https://download.pytorch.org/whl/cu118"

[[tool.uv.index]]
name = "torch-cu124"
url = "https://download.pytorch.org/whl/cu124"
@charliermarsh charliermarsh added the enhancement New feature or improvement to existing functionality label Sep 28, 2024
@charliermarsh charliermarsh self-assigned this Sep 28, 2024
@charliermarsh charliermarsh mentioned this issue Sep 28, 2024
Merged
charliermarsh added a commit that referenced this issue Oct 15, 2024
@charliermarsh
Allow multiple pinned indexes in tool.uv.sources (#7769)
9a76e47 
## Summary

This PR lifts the restriction that a package must come from a single
index. For example, you can now do:

```toml
[project]
name = "project"
version = "0.1.0"
readme = "README.md"
requires-python = ">=3.12"
dependencies = ["jinja2"]

[tool.uv.sources]
jinja2 = [
    { index = "torch-cu118", marker = "sys_platform == 'darwin'"},
    { index = "torch-cu124", marker = "sys_platform != 'darwin'"},
]

[[tool.uv.index]]
name = "torch-cu118"
url = "https://download.pytorch.org/whl/cu118"

[[tool.uv.index]]
name = "torch-cu124"
url = "https://download.pytorch.org/whl/cu124"
```

The construction is very similar to the way we handle URLs today: you
can have multiple URLs for a given package, but they must appear in
disjoint forks. So most of the code is just adding that abstraction to
the resolver, following our handling of URLs.

Closes #7761.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
enhancement New feature or improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@charliermarsh