Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be compatible with non-PEP440 version under env var UV_NON_PEP440_COMPAT #11434

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JakkuSakura
Copy link

@JakkuSakura JakkuSakura commented Feb 12, 2025

Summary

Under env var UV_NON_PEP440_COMPAT, the version parser will tolerate non-PEP440 versions like the legacy pip. This will probably fix #5478

Test Plan

Tests included

Copy link

codspeed-hq bot commented Feb 12, 2025

CodSpeed Performance Report

Merging #11434 will degrade performances by 13.14%

Comparing JakkuSakura:version-compat (5dac27b) with main (1cd9c37)

Summary

❌ 1 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
wheelname_tag_compatibility[flyte-short-incompatible] 771.4 ns 888.1 ns -13.14%

@JakkuSakura
Copy link
Author

Seems the CI for windows is random and unrelated

@zanieb zanieb requested a review from konstin February 12, 2025 14:49
@konstin konstin requested review from charliermarsh and removed request for konstin February 12, 2025 16:04
@charliermarsh
Copy link
Member

I appreciate the PR but I'd prefer not to support this. It seems to be a violation of standards. What's the concrete problem you're trying to solve?

@JakkuSakura
Copy link
Author

Understood. We are migrating our legacy python codebase to latest python version and ecosystem. Our versioning is non-standard because our codebase predates the standard. Having this feature help us to migrate our projects to uv. Without this, it's not possible to use tools other than legacy pip and setup.py. Fixing them one by one would take a long time.

I hoped to help other users with this PR, but fine just living in a fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error installing wheel with "invalid version"
2 participants