Automatically detect virtual environments when used via python -m uv
#1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @altendky :) |
henryiii
reviewed
Feb 16, 2024
python/uv/__main__.py
Outdated
| return value | ||
|
|
||
| # Otherwise, check if we're in a venv | ||
| maybe_venv_dir = os.path.dirname(os.path.dirname(sys.executable)) |
There was a problem hiding this comment.
Shouldn't this be something like (Path(sys.prefix) / "pyvenv.cfg").exists() (probably without the pathlib for speed, but I'm lazy here)? This assumes that there is exactly one level between the bin or Scripts dir and the base prefix, which I don't think is guaranteed.
There was a problem hiding this comment.
Thanks! I thought what I was doing might be brittle.. let me look into that.
There was a problem hiding this comment.
https://docs.python.org/3/library/sysconfig.html#installation-paths Looks like you can sometimes get a posix_prefix. Might lead to more details about 'correctness' as well.
|
Thanks! $ python3.11 -m venv venv$ venv/bin/python -m pip install 'uv @ git+https://github.com/astral-sh/uv@1ed6ba0ba0d3756312085ec21c90469985b5bbb6'
Collecting uv@ git+https://github.com/astral-sh/uv@1ed6ba0ba0d3756312085ec21c90469985b5bbb6
Using cached uv-0.1.2-py3-none-linux_x86_64.whl
Installing collected packages: uv
Successfully installed uv-0.1.2
[notice] A new release of pip is available: 23.2.1 -> 24.0
[notice] To update, run: /home/altendky/tmp/venv/bin/python -m pip install --upgrade pipInstalled $ venv/bin/python -m uv pip install attrs
error: Failed to locate a virtualenv or Conda environment (checked: `VIRTUAL_ENV`, `CONDA_PREFIX`, and `.venv`). Run `uv venv` to create a virtualenv.$ venv/bin/python -m pip install 'uv @ git+https://github.com/astral-sh/uv@967188a914df3461b92de27e9b9234fd8c22be85'
Collecting uv@ git+https://github.com/astral-sh/uv@967188a914df3461b92de27e9b9234fd8c22be85
Using cached uv-0.1.1-py3-none-linux_x86_64.whl
Installing collected packages: uv
Attempting uninstall: uv
Found existing installation: uv 0.1.2
Uninstalling uv-0.1.2:
Successfully uninstalled uv-0.1.2
Successfully installed uv-0.1.1
[notice] A new release of pip is available: 23.2.1 -> 24.0
[notice] To update, run: /home/altendky/tmp/venv/bin/python -m pip install --upgrade pipInstalled this PR above and see it succeeding below. $ venv/bin/python -m uv pip install attrs
Resolved 1 package in 107ms
Installed 1 package in 9ms
+ attrs==23.2.0 |
This was referenced Feb 17, 2024
zanieb
added a commit
that referenced
this pull request
Feb 18, 2024
…#1667) From #1623 (comment) I thought I checked this was working correctly in #1504 but I guess the environment is not preserved like I thought.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1501