Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change indent to sensible value #1540

Merged
merged 1 commit into from
Feb 16, 2024
Merged

change indent to sensible value #1540

merged 1 commit into from
Feb 16, 2024

Conversation

BurntSushi
Copy link
Member

No description provided.

MichaReiser
MichaReiser approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a very opinionated commit message ;)

zanieb
zanieb approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚲

@MichaReiser MichaReiser added the internal A refactor or improvement that is not user-facing label Feb 16, 2024
AlexWaygood
AlexWaygood approved these changes Feb 16, 2024
View reviewed changes
.editorconfig
indent_size = 4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or do what we do at ruff?

Suggested change
indent_size = 4
indent_size = 2
[*.{rs,py,pyi}]
indent_size = 4

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. PR updated to just be a copy of what's in Ruff.

@BurntSushi BurntSushi merged commit 7c08e61 into main Feb 16, 2024
7 checks passed
@BurntSushi BurntSushi deleted the ag/fix-indent branch February 16, 2024 21:11
@branchvincent branchvincent mentioned this pull request Feb 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@zanieb zanieb zanieb approved these changes

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees
No one assigned
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BurntSushi @MichaReiser @zanieb @AlexWaygood