Respect --index-url provided via requirements.txt
#1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/inde
branch
3 times, most recently
from
d25423a
to
97f669f
Compare
charliermarsh
force-pushed
the
charlie/inde
branch
from
97f669f
to
f89ded9
Compare
charliermarsh
force-pushed
the
charlie/inde
branch
from
f89ded9
to
73e712c
Compare
charliermarsh
force-pushed
the
charlie/inde
branch
from
73e712c
to
994fb60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we read
--index-urlfrom arequirements.txt, we attempt to respect the--index-urlprovided by the CLI if it exists. Unfortunately,--index-urlfrom the CLI has a default value... so we never respect the--index-urlin the requirements file.This PR modifies the CLI to use
None, and moves the default into logic in theIndexLocationsstruct.Closes #1692.