Backport changes from publish crates #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport of changes for the published new versions of pep440_ra and pep508_rs to make it easier to keep them in sync.
charliermarsh
approved these changes
Feb 20, 2024
| @@ -69,7 +69,7 @@ plist = { version = "1.6.0" } | |||
| pubgrub = { git = "https://github.com/zanieb/pubgrub", rev = "9b6d89cb8a0c7902815c8b2ae99106ba322ffb14" } | |||
| pyo3 = { version = "0.20.2" } | |||
| pyo3-log = { version = "0.9.0"} | |||
| pyproject-toml = { version = "0.8.1" } | |||
| pyproject-toml = { version = "0.10.0" } | |||
There was a problem hiding this comment.
Can you double-check that this is using our local versions of the PEP crates, patched below? I think it is, since you bumped the version, but please double-check.
There was a problem hiding this comment.
Good point, i checked and we only have one version of both in Cargo.lock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of changes for the published new versions of pep440_rs and pep508_rs to make it easier to keep them in sync.