Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos configuration #1742

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Fix typos configuration #1742

merged 1 commit into from
Feb 20, 2024

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Feb 20, 2024

Summary

Narrow down excludes for typos and fix 2 additional misspellings.

BTW pre-commit can be run in CI: https://github.com/szepeviktor/pre-commit-on-you/actions/runs/7971275239/job/21760614908

@@ -1,12 +1,17 @@
[files]
extend-exclude = [
"**/resources/**/*",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These directories do not exist.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh this was copy-pasted from Ruff a long time ago.

Comment on lines -4 to +3
"**/snapshots/**/*",
"**/snapshots/",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An ending / is enough.

"scripts/**/*.in",
]
ignore-hidden = false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😲 check dotfiles.

Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh added the bug Something isn't working label Feb 20, 2024
@charliermarsh charliermarsh merged commit c191a83 into astral-sh:main Feb 20, 2024
7 checks passed
@charliermarsh charliermarsh added internal A refactor or improvement that is not user-facing and removed bug Something isn't working labels Feb 20, 2024
@szepeviktor szepeviktor deleted the typos branch February 20, 2024 15:09
@szepeviktor
Copy link
Contributor Author

Glad to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants