Skip compile_html test on musl #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The torch index has no musllinux wheel, so we need to skip the test on alpine.
.gitignore
Outdated
| @@ -4,7 +4,7 @@ | |||
| # Generated by Cargo | |||
| # will have compiled files and executables | |||
| debug/ | |||
| target/ | |||
| target* | |||
konstin
commented
Feb 20, 2024
.gitignore
Outdated
| @@ -4,7 +4,7 @@ | |||
| # Generated by Cargo | |||
| # will have compiled files and executables | |||
| debug/ | |||
| target/ | |||
| target* | |||
There was a problem hiding this comment.
This helps when setting CARGO_TARGET_DIR="target-alpine" when both the host and the docker think they are the default target
There was a problem hiding this comment.
Feels like it maybe belongs in a personal .gitignore. Can we at least change to target-alpine/? Otherwise I worry this will cause a confusing behavior in the future when we forget about it.
charliermarsh
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The torch index has no musllinux wheel, so we need to skip the test on alpine.