feat: add installer to InstalledDist
#1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -111,6 +111,15 @@ impl InstalledDist { | |||
| }) | |||
| } | |||
|
|
|||
| /// Return the `INSTALLER` of the distribution. | |||
| pub fn installer(&self) -> Option<String> { | |||
There was a problem hiding this comment.
Do you mind making this Result<Option<String>>, and erroring if the error kind is anything other than "not found"?
There was a problem hiding this comment.
(I feel like the direct_url method above should function similarly, but that doesn't need to be changed here.)
There was a problem hiding this comment.
Gonna change this so that I can include it in the release.
charliermarsh
added
the
internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
installermethod toInstalledDistto distinguish between different installers. Might be nice to add an enum for all possible installers, but this might be too hard to keep up to date :).The
INSTALLERfile is a file that can be added to the.dist-infofolder with the installer name.Closes: #1759
Test Plan
Not sure if there is a place I can automatically test it, if you have a pointer I would be happy to add a test.