Treat ARM wheels as higher-priority than universal #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Feb 22, 2024
crates/platform-tags/src/lib.rs
Outdated
| @@ -253,6 +253,18 @@ impl TryFrom<usize> for TagPriority { | |||
| } | |||
| } | |||
|
|
|||
| impl Ord for TagPriority { | |||
| fn cmp(&self, other: &Self) -> cmp::Ordering { | |||
| self.0.cmp(&other.0).reverse() | |||
There was a problem hiding this comment.
(Not sure if there's a better way to do this.)
|
This will probably fix a variety of ARM failures. |
|
@BurntSushi caught that this is the wrong fix -- there's a What's wrong is the priority ordering of some tags. |
charliermarsh
force-pushed
the
charlie/priority
branch
from
2bdf732
to
f6a639d
Compare
BurntSushi
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We need to take care to keep wheel tags in "priority order" (e.g., we should prefer ARM wheels over universal wheels). However... it looks like we've had a
.sort()in here all along, that risks throwing off the ordering?Closes #1840.
Test Plan
ensure that
rlaxuses the ARM wheel rather than the universal wheel:cargo run venvcargo run pip install rlaximport rlax