-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove --upgrade
and --quiet
flags from generated output files
#1873
Remove --upgrade
and --quiet
flags from generated output files
#1873
Conversation
1e64d71
to
06273e7
Compare
@@ -393,7 +404,13 @@ pub(crate) async fn pip_compile( | |||
} | |||
|
|||
/// Format the `uv` command used to generate the output file. | |||
fn cmd(include_index_url: bool, include_find_links: bool) -> String { | |||
#[allow(clippy::fn_params_excessive_bools)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm new to Rust and I didn't come up with a good idea to avoid the clippy warning. I'd appreciate it if you suggest a better way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what you have here is ok!Tthough I'm gonna remove the arguments because I think we should just always omit these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay! Thank you for your comment.
Thanks @yasufumy! |
Summary
Resolve #1814
I changed the behavior of
pip compile
to not display--upgrade
(-U
) and--quiet
(-q
) for compatibility