Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uv-created venv detection #1908

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

konstin
Copy link
Member

@konstin konstin commented Feb 23, 2024

Read the key read for uv from pyenv.cfg from gourgeist instead of uv. I missed that we're also reading pyenv.cfg when reviewing #1852. We could check for gourgeist for backwards compatibility, but i think it's fine this way.

@konstin konstin added the bug Something isn't working label Feb 23, 2024
Read the key read for uv from `pyenv.cfg` from `gourgeist` to `uv`. I missed that we're also reading pyenv.cfg when reviewing #1852.
@konstin konstin force-pushed the konsti/fix-venv-creator-detection branch from 3e1becb to 20d4e4f Compare February 23, 2024 12:10
Copy link
Member

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Out of curiosity, what impact was this bug having at an end-user level? (I'm just trying to understand the context of the change a little more.)

@konstin
Copy link
Member Author

konstin commented Feb 23, 2024

We use this to determine whether to remove the seed packages: Keep if they came from virtualenv/venv, remove if they were installed by uv.

@zanieb zanieb merged commit 62023ea into main Feb 23, 2024
7 checks passed
@zanieb zanieb deleted the konsti/fix-venv-creator-detection branch February 23, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants