Invalidate dependencies when editables are updated #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/validate
branch
from
9d5f693
to
5d9366d
Compare
charliermarsh
force-pushed
the
charlie/validate
branch
from
5d9366d
to
2cf7937
Compare
charliermarsh
force-pushed
the
charlie/validate
branch
from
2cf7937
to
92104da
Compare
charliermarsh
added a commit
that referenced
this pull request
Feb 25, 2024
yasufumy
pushed a commit
to yasufumy/uv
that referenced
this pull request
Feb 25, 2024
## Summary If a `pyproject.toml` or similar is changed within an editable, we should avoid passing our audit check (and thus re-install the package). Closes astral-sh#1913.
yasufumy
pushed a commit
to yasufumy/uv
that referenced
this pull request
Feb 25, 2024
## Summary Like astral-sh#1955, but for `pip sync`. Closes astral-sh#1957.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a
pyproject.tomlor similar is changed within an editable, we should avoid passing our audit check (and thus re-install the package).Closes #1913.