Expand scope of archive timestamping #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/setup
branch
from
e34ab99
to
812b9cf
Compare
yasufumy
pushed a commit
to yasufumy/uv
that referenced
this pull request
Feb 25, 2024
## Summary Instead of looking at _either_ `pyproject.toml` or `setup.py`, we should just be conservative and take the most-recent timestamp out of `pyproject.toml`, `setup.py`, and `setup.cfg`. That will help prevent staleness issues like those described in astral-sh#1913 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of looking at either
pyproject.tomlorsetup.py, we should just be conservative and take the most-recent timestamp out ofpyproject.toml,setup.py, andsetup.cfg. That will help prevent staleness issues like those described in #1913 (comment).