Don't write pip compile output to stdout with -q
#1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Feb 25, 2024
| @@ -1,2 +0,0 @@ | |||
| apache-airflow[otel] | |||
| opentelemetry-exporter-prometheus<0.44 | |||
There was a problem hiding this comment.
(Accidentally included in a prior PR.)
charliermarsh
force-pushed
the
charlie/editable
branch
from
122f39a
to
3f83937
Compare
yasufumy
pushed a commit
to yasufumy/uv
that referenced
this pull request
Feb 25, 2024
## Summary When the user provides an output file, avoid writing the `pip compile` output to `stdout` when `-q` is specified. (We still write to `stdout` if no output file is provided, since otherwise, the resolution won't be printed _anywhere_.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the user provides an output file, avoid writing the
pip compileoutput tostdoutwhen-qis specified. (We still write tostdoutif no output file is provided, since otherwise, the resolution won't be printed anywhere.)