Always remove color codes from output file #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always strip color codes when we're writing to a file. I don't really know how to test this. Fixes #2017
charliermarsh
approved these changes
Feb 27, 2024
|
I don't understand why the autostream doesn't work here. |
zanieb
approved these changes
Feb 27, 2024
|
It seems that we eventually call |
|
It is very mysterious, but it seems like this might be the likely explanation: Something in ipython sets CLICOLOR_FORCE=1 and autostream listens to this env variable as well as a few others. Maybe this is the culprit: https://github.com/ipython/ipykernel/blob/c1d944ece0eaeb5b1ea030f22a0e259d8fd915fd/ipykernel/zmqshell.py#L503-L504 confirmed by workaround also related, maybe rust-cli/anstyle#178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always strip color codes when we're writing to a file.
I don't really know how to test this.
Fixes #2017