Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include exit code for build failures #2108

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Conversation

konstin
Copy link
Member

@konstin konstin commented Mar 1, 2024

uv pip install mysqlclient==2.1.1 on python 3.12 on windows, where the are no binary wheels:

grafik

Part of #2052.

@konstin konstin added the error messages Messaging when something goes wrong label Mar 1, 2024
@konstin konstin force-pushed the konsti/add-exit-status branch 2 times, most recently from 3ed40c8 to 8190371 Compare March 1, 2024 11:36
@charliermarsh
Copy link
Member

I'm finding it hard to tell which exit code belongs to which process, since exit code: 2 appears twice and exit code: 1 appears once. How does pip lay it out in this case?

@konstin
Copy link
Member Author

konstin commented Mar 1, 2024

Sharing linux now, windows after a reboot.

The linux comparison is asymmetric since we never call egg_info:

pip

image

uv

image

@konstin
Copy link
Member Author

konstin commented Mar 1, 2024

Windows, my IDE terminal

pip

It's cut off because that's my screen height.

grafik

uv

grafik

Default size windows terminal (powershell)

pip

grafik

uv

grafik

Full height windows terminal (powershell)

This time a side-by-side view

grafik

@konstin
Copy link
Member Author

konstin commented Mar 1, 2024

I'm thinking about adding a message at the bottom after the stdout/stderr so it's immediately clear what failed even if setuptools and compilers spill so much output that it scrolled multiple pages.

@charliermarsh charliermarsh enabled auto-merge (squash) March 6, 2024 00:51
@charliermarsh charliermarsh merged commit df06069 into main Mar 6, 2024
7 checks passed
@charliermarsh charliermarsh deleted the konsti/add-exit-status branch March 6, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error messages Messaging when something goes wrong
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants