Treat empty index URL strings as null instead of erroring #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Ok(url) => Ok(url), | ||
| Err(err) => Err(err.to_string()), | ||
| } | ||
| } |
There was a problem hiding this comment.
I think empty should probably map to None rather than PyPI. The difference is subtle but if a user has an --index-url in a requirements.txt, and they specify UV_INDEX_URL=, we should probably respect the index URL in the requirements.txt rather than overriding to PyPI (which will be accomplished by mapping this to None).
There was a problem hiding this comment.
Playing around with this myself and Clap doesn't make it easy.
charliermarsh
force-pushed
the
fix/index-url-parser
branch
2 times, most recently
from
1c79751
to
358db13
Compare
charliermarsh
added
the
compatibility
charliermarsh
force-pushed
the
fix/index-url-parser
branch
from
358db13
to
241af48
Compare
zanieb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #2129
I changed the behavior to parse an empty string for
--index-urlto be the same as the default.