Error when direct URL requirements don't match Requires-Python
#2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
bug
charliermarsh
commented
Mar 5, 2024
| if range.contains(&version) { | ||
| Ok(Some(ResolverVersion::Available(version))) | ||
| } else { | ||
| Ok(None) |
There was a problem hiding this comment.
We have to get rid of this "fast path", because we now need the Requires-Python here.
Alternatively, we could move the Requires-Python check into get_dependencies for URL dependencies.
charliermarsh
force-pushed
the
charlie/req-ii
branch
2 times, most recently
from
ae0edee
to
16fabe5
Compare
charliermarsh
force-pushed
the
charlie/req-ii
branch
from
16fabe5
to
7060cd4
Compare
zanieb
reviewed
Mar 13, 2024
zanieb
approved these changes
Mar 13, 2024
charliermarsh
force-pushed
the
charlie/req-ii
branch
from
7060cd4
to
ee6655c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2195.
Test Plan
cargo test