Respect nested editable requirements in parser #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Mar 5, 2024
| } | ||
| self.extra_index_urls.extend(extra_index_urls); | ||
| self.find_links.extend(find_links); | ||
| self.no_index = self.no_index || no_index; |
There was a problem hiding this comment.
We missed incorporating these extra fields when they were added to RequirementsTxt.
charliermarsh
force-pushed
the
charlie/ed
branch
from
556932c
to
9e83074
Compare
zanieb
approved these changes
Mar 5, 2024
charliermarsh
force-pushed
the
charlie/ed
branch
4 times, most recently
from
281c7fe
to
bfd7d15
Compare
charliermarsh
force-pushed
the
charlie/ed
branch
from
bfd7d15
to
18af3f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2198.