Add backoff for transient Windows failures #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/backoff
branch
from
9ec4247
to
0959ac8
Compare
charliermarsh
added
bug
charliermarsh
commented
Mar 13, 2024
| @@ -206,7 +206,7 @@ impl Cache { | |||
| } | |||
|
|
|||
| /// Persist a temporary directory to the artifact store. | |||
| pub fn persist( | |||
| pub async fn persist( | |||
There was a problem hiding this comment.
Important that this is async now because we don't want to block the thread during the backoff phase.
konstin
approved these changes
Mar 13, 2024
zanieb
added a commit
that referenced
this pull request
Jun 28, 2024
#2419 appears to have only applied this retry to wheels that were already downloaded (though I would have to look more carefully to be certain). In #1491, we've gotten continued reports of spurious failures on Windows and tracing reveals that we are not applying our retry logic during the rename. I believe we're in this code path — switching to our backoff retry should resolve the failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This may be required elsewhere, but all the traces in that issue are related to persisting the temporary directory to our persistent cache, so lets start there.
See: #1491.