Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in-URL credentials to store prior to creating requests #2446

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

charliermarsh
Copy link
Member

Summary

The authentication middleware extracts in-URL credentials from URLs that pass through it; however, by the time a request reaches the store, the credentials will have already been removed, and relocated to the header. So we were never propagating in-URL credentials.

This PR adds an explicit pass wherein we pass in-URL credentials to the store prior to doing any work.

Closes #2444.

Test Plan

cargo run pip install against an authenticated AWS registry.

@charliermarsh charliermarsh added the bug Something isn't working label Mar 14, 2024
@charliermarsh charliermarsh force-pushed the charlie/auth branch 3 times, most recently from bf435a3 to ecf6fce Compare March 14, 2024 03:25
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll investigate other approaches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 0.1.19 breaks AWS CodeArtifact authentication
2 participants