Add support for Hatch's {root:uri} paths in editable installs
#2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
the
compatibility
charliermarsh
changed the title
{root:uri} paths in editable installs
charliermarsh
force-pushed
the
charlie/b
branch
from
1a5ac9d
to
02b9253
Compare
charliermarsh
force-pushed
the
charlie/b
branch
from
02b9253
to
9aef203
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a package uses Hatch's
root.urifeature, we currently error:Even though we're using PEP 517 hooks to get the metadata, which should support this. The problem is that we load the full
PyProjectToml, which means we parse the requirements, which means we reject what looks like a relative URL in dependencies.Instead, we should only enforce a limited subset of
pyproject.toml(arguably none).Closes #2475.