Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add support for pyenv shims #2503

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Re-add support for pyenv shims #2503

merged 1 commit into from
Mar 18, 2024

Conversation

charliermarsh
Copy link
Member

Summary

By running get_interpreter_info.py outside of the current working directory, we seem to have broken pyenv shims.

Closes #2488.

Test Plan

Without this change (resolving to the Homebrew Python, even though we start with a shim):

DEBUG Starting interpreter discovery for Python @ `python3.11`
DEBUG Probing interpreter info for: /Users/crmarsh/.pyenv/shims/python3.11
DEBUG Found Python 3.11.7 for: /Users/crmarsh/.pyenv/shims/python3.11
Using Python 3.11.7 interpreter at: /opt/homebrew/opt/python@3.11/bin/python3.11
Creating virtualenv at: .venv
INFO Removing existing directory
Activate with: source .venv/bin/activate

With this change:

DEBUG Starting interpreter discovery for Python @ `python3.11`
DEBUG Probing interpreter info for: /Users/crmarsh/.pyenv/shims/python3.11
DEBUG Found Python 3.11.1 for: /Users/crmarsh/.pyenv/shims/python3.11
Using Python 3.11.1 interpreter at: /Users/crmarsh/.pyenv/versions/3.11.1/bin/python3.11
Creating virtualenv at: .venv
INFO Removing existing directory
Activate with: source .venv/bin/activate

@charliermarsh charliermarsh added the bug Something isn't working label Mar 18, 2024
@charliermarsh
Copy link
Member Author

I'll look into adding a test for this: #2504

@charliermarsh charliermarsh merged commit a07438f into main Mar 18, 2024
30 checks passed
@charliermarsh charliermarsh deleted the charlie/pyenv branch March 18, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.1.19 regression] uv no longer uses the Python interpreter set by pyenv
1 participant