Use relative paths for user display #2559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 I prefer this strongly. I would be careful with cases where the user provides something relative but stepping upwards like |
charliermarsh
force-pushed
the
charlie/relativize
branch
3 times, most recently
from
e3454e3
to
19856a4
Compare
charliermarsh
force-pushed
the
charlie/relativize
branch
from
19856a4
to
150dd65
Compare
charliermarsh
force-pushed
the
charlie/relativize
branch
5 times, most recently
from
524e2fa
to
1b1821c
Compare
charliermarsh
force-pushed
the
charlie/relativize
branch
from
1b1821c
to
f63f4c9
Compare
charliermarsh
requested review from
zanieb and
konstin
and removed request for
zanieb
konstin
approved these changes
Mar 20, 2024
| "Activate with: source /home/ferris/project/.venv/bin/activate", | ||
| ), | ||
| (filter_prompt, "Activate with: source .venv/bin/activate"), | ||
| (&filter_venv, ".venv"), |
There was a problem hiding this comment.
Yeah, for some reason on macOS these paths are sometimes prefixed with /private/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes our user-facing representation for paths to use relative paths, when the path is within the current working directory. This mirrors what we do in Ruff. (If the path is outside the current working directory, we print an absolute path.)
Before:
❯ uv venv .venv2 Using Python 3.12.2 interpreter at: /Users/crmarsh/workspace/uv/.venv/bin/python3 Creating virtualenv at: .venv2 Activate with: source .venv2/bin/activateAfter:
❯ cargo run venv .venv2 Finished dev [unoptimized + debuginfo] target(s) in 0.15s Running `target/debug/uv venv .venv2` Using Python 3.12.2 interpreter at: .venv/bin/python3 Creating virtualenv at: .venv2 Activate with: source .venv2/bin/activateNote that we still want to use the existing
.simplified_display()anywhere that the path is being simplified, but still intended for machine consumption (e.g., when passing to.current_dir()).