Update minimum rust version (cargo) to 1.76 #2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should address (fix?) #2442, it blocks building with a version that doesn't support return type impl trait. ``` $ cargo +1.74 check error: package `pep508_rs v0.4.2 (/home/konsti/projects/uv/crates/pep508-rs)` cannot be built because it requires rustc 1.76 or newer, while the currently active rustc version is 1.74.1 ``` While we should encourage our dependencies to set a msrv, if we set our rust-toolchain.toml version as cargo msrv our users on no-wheel no-installer platforms will also be fine (or at least get helpful error messages).
charliermarsh
approved these changes
Mar 22, 2024
zanieb
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address (fix?) #2442, it blocks building with a version that doesn't support return type impl trait.
While we should encourage our dependencies to set a msrv, if we set our rust-toolchain.toml version as cargo msrv our users on no-wheel no-installer platforms will also be fine (or at least get helpful error messages).