Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept setup.py and setup.cfg files in compile #2634

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Accept setup.py and setup.cfg files in compile #2634

merged 1 commit into from
Mar 25, 2024

Conversation

charliermarsh
Copy link
Member

Summary

This costs us ~nothing now that we support using PEP 517 hooks for pyproject.toml.

Test Plan

cargo test

@charliermarsh charliermarsh added enhancement New feature or improvement to existing functionality compatibility Compatibility with a specification or another tool labels Mar 23, 2024
@charliermarsh charliermarsh marked this pull request as ready for review March 23, 2024 02:35
@charliermarsh charliermarsh force-pushed the charlie/setup-iii branch 2 times, most recently from f285623 to b44d083 Compare March 23, 2024 03:02
zanieb
zanieb approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add an example to the README alongside the other sources?

@charliermarsh charliermarsh force-pushed the charlie/setup-ii branch 3 times, most recently from 3bea576 to 4b2f249 Compare March 25, 2024 20:21
Base automatically changed from charlie/setup-ii to main March 25, 2024 20:27
@charliermarsh charliermarsh enabled auto-merge (squash) March 25, 2024 20:32
@charliermarsh charliermarsh merged commit ae35a21 into main Mar 25, 2024
31 checks passed
@charliermarsh charliermarsh deleted the charlie/setup-iii branch March 25, 2024 20:39
@BrewTestBot BrewTestBot mentioned this pull request Mar 28, 2024
Merged
@palfrey palfrey mentioned this pull request Apr 28, 2024
Closed
@amercader amercader mentioned this pull request Sep 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
compatibility Compatibility with a specification or another tool enhancement New feature or improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charliermarsh @zanieb