Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow pyproject.toml from pip uninstall #2663

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Mar 26, 2024

Summary

Passing pyproject.toml or setup.py to pip uninstall is a bit strange, since it will often require running a resolution to resolve the dependencies (e.g., build the project), which means we also need to accept --index-url and friends.

@charliermarsh charliermarsh changed the title Disallow pyproject.toml in pip sync and pip uninstall Disallow pyproject.toml in pip sync and pip uninstall Mar 26, 2024
@charliermarsh
Copy link
Member Author

I'm open to allowing it for pip uninstall if there's pushback. It's more work and I'll need to wire up all the arguments, but it's doable.

@charliermarsh charliermarsh marked this pull request as ready for review March 26, 2024 00:54
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uninstall seems like a really weird use case..

sync seems reasonable if we performed resolution... seems better for a future interface though.

@charliermarsh charliermarsh force-pushed the charlie/pyproj branch 2 times, most recently from d7f8382 to 50dea9c Compare March 26, 2024 01:20
@charliermarsh charliermarsh changed the title Disallow pyproject.toml in pip sync and pip uninstall Disallow pyproject.toml from pip uninstall Mar 26, 2024
@charliermarsh charliermarsh added the cli Related to the command line interface label Mar 26, 2024
@charliermarsh
Copy link
Member Author

I changed it to just pip uninstall for now, since that's what was blocking me elsewhere.

@charliermarsh charliermarsh merged commit 12846c2 into main Mar 26, 2024
31 checks passed
@charliermarsh charliermarsh deleted the charlie/pyproj branch March 26, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the command line interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants