Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UV_RESOLUTION environment variable for --resolution #2720

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Add UV_RESOLUTION environment variable for --resolution #2720

merged 1 commit into from
Mar 28, 2024

Conversation

charliermarsh
Copy link
Member

Closes #2710.

@charliermarsh charliermarsh added the configuration Settings and such label Mar 28, 2024
@charliermarsh charliermarsh marked this pull request as ready for review March 28, 2024 20:34
@charliermarsh charliermarsh changed the title Add UV_RESOLUTION environment variable for --resolution Add UV_RESOLUTION environment variable for --resolution Mar 28, 2024
@zanieb
Copy link
Member

zanieb commented Mar 28, 2024

I find it a little weird that it's not UV_RESOLUTION_MODE (and --resolution-mode I guess?)

@charliermarsh
Copy link
Member Author

I can change it. But it's not --prerelease-mode either.

zanieb
zanieb approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can think about that more later

@charliermarsh charliermarsh merged commit ce5df77 into main Mar 28, 2024
33 checks passed
@charliermarsh charliermarsh deleted the charlie/resol branch March 28, 2024 21:08
@BrewTestBot BrewTestBot mentioned this pull request Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
configuration Settings and such
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: Support UV_RESOLUTION environment variable
2 participants
@charliermarsh @zanieb